Re: [pgAdmin][RM4768] Reverse proxy on non-standard port

On Tue, Oct 1, 2019 at 3:16 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the updated patch.
> Changes are made to not to apply ProxyFix if it is not available. Plus,
> requirements.txt is updated to Werkzeug>=0.15.0
>
> It looks good to me except  Werkzeug>=0.15.0.
Can we make it  Werkzeug>0.15.0, this will ensure to upgrade it whenever
new version is available.

> Kindly review.
>
> On Tue, Oct 1, 2019 at 2:07 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> I forgot to change the virtualenv in another terminal Tab, I am getting
>> error
>>
>> TypeError: __init__() got an unexpected keyword argument ‘x_for’
>>
>> with Flask 1.0.2.
>>
>> Regards,
>> Murtuza
>>
>> On Tue, Oct 1, 2019 at 1:35 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi Aditya,
>>>
>>> Tested with below version and works fine.
>>>
>>> >>> flask.__version__
>>> '1.0.2'
>>> >>> werkzeug.__version__
>>> '0.14.1'
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>> On Tue, Oct 1, 2019 at 12:04 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> I have added a backward compatible code in cases werkzeug is older.
>>>> This will never happen considering we use Flask 1.0.2.
>>>> Attached is the precautionary patch.
>>>>
>>>> On Fri, Sep 27, 2019 at 1:29 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Thanks, patch applied.
>>>>>
>>>>> On Fri, Sep 27, 2019 at 12:17 PM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is the patch to allow pgAdmin to run behind reverse proxy on
>>>>>> a non standard port.
>>>>>> The middleware -
>>>>>> https://werkzeug.palletsprojects.com/en/0.15.x/middleware/proxy_fix/#werkzeug.middleware.proxy_fix.ProxyFix
>>>>>> allows us to set the number of trusted ports (and few other params) behind
>>>>>> the proxy. By default it is zero.
>>>>>> With this patch, user can set these params using pgAdmin config.
>>>>>> I have set the default value for port as 1, which will allow to run
>>>>>> behind non-standard port.
>>>>>>
>>>>>> I have added the documentation under reverse proxy section.
>>>>>>
>>>>>> Kindly review.
>>>>>>
>>>>>> --
>>>>>> Thanks and Regards,
>>>>>> Aditya Toshniwal
>>>>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>