Re: [pgAdmin][RM4728] more strongly highlight the closing or opening parenthesis when the cursor is over one
Aditya Toshniwal <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CAM9w-_kW3x2SF_1aziahMaT90_U1b-4TwkWsQXZS7_KM8FRR4Q@mail.gmail.com> |
Hi, Please find attached patch. Forgot to attach. On Thu, Oct 3, 2019 at 4:46 PM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > Attached is a tiny patch to change the colour of matching braces > highlighting in Codemirror. > Below is the before and after: > [image: Screenshot 2019-10-03 at 16.43.22.png][image: Screenshot > 2019-10-03 at 16.42.09.png] > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
Screenshot 2019-10-03 at 16.42.09.png
(image/png, 69.1 KB) - not displayed
Screenshot 2019-10-03 at 16.43.22.png
(image/png, 68.5 KB) - not displayed
RM4728.patch
(application/x-patch, 1.2 KB)
diff --git a/web/pgadmin/static/scss/_codemirror.overrides.scss b/web/pgadmin/static/scss/_codemirror.overrides.scss
index a6775246..1d5d689b 100644
--- a/web/pgadmin/static/scss/_codemirror.overrides.scss
+++ b/web/pgadmin/static/scss/_codemirror.overrides.scss
@@ -3,8 +3,8 @@
}
/* To override inbuilt Green color for matchingbracket */
.cm-s-default .CodeMirror-matchingbracket {
- color: $color-gray-dark !important;
- background-color: $color-gray-lighter !important;
+ color: $sql-bracket-match-fg !important;
+ background-color: $sql-bracket-match-bg !important;
}
.CodeMirror {
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index 09aaf8ae..55507a33 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -197,6 +197,8 @@ $sql-history-error-fg: $color-danger;
$sql-hint-bg: $color-bg-theme;
$sql-hint-active-bg: $color-primary;
$sql-hint-active-fg: $white;
+$sql-bracket-match-fg: $color-gray-darker;
+$sql-bracket-match-bg: #f5d2af;
$negative-bg: $color-gray-light;
$dialog-box-shadow: $box-shadow;