[pgAdmin][RM4845] Potential error in properties dialog for Code tab

Ganesh Jaybhay <[email protected]> Thu, 17 Oct 2019 14:38:48 +0530

Newsgroups	gmane.comp.db.postgresql.pgadmin.devel
Message-ID	<CAK6syAqdfBkOs2TMKCFTXtu6oezrRmcM4tbMK6UPzXy2VOkvxQ@mail.gmail.com>

Hi Hackers,

Please find the attached minor patch to fix the potential error if
'tabPanelCodeClass' is not passed while creating dialog.
Kindly review.

Regards,
Ganesh Jaybhay

RM4845.patch (application/octet-stream, 529 B)

diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 4568f0f..3dfe46d 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -689,6 +689,7 @@ define([
         }
         var el = $((tmpls['panel'])(_.extend(o, {
           'tabIndex': idx,
+          'tabPanelCodeClass': o.tabPanelCodeClass ? o.tabPanelCodeClass : '',
         })))
           .appendTo(tabContent)
           .removeClass('collapse').addClass('collapse');