Re: [pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others

Akshay Joshi <[email protected]>
Newsgroups gmane.comp.db.postgresql.pgadmin.devel
Message-ID <CANxoLDcZn6timgdxUDX1Jm=usRKn2FEveF8DV=FSno3KSMuBPA@mail.gmail.com>
Hi Rahul

Following are the review comments:

   - Priority should be set to 5 instead of 997, as the 'Remove Server'
   menu goes very down with that priority. 'Remove Server' menu should be near
   to 'Connect Server' and 'Disconnect Server'. I have tested it with 5 and it
   looks fine. Refer the below screenshot

                                 [image: Screenshot 2019-11-05 at 3.27.22
PM.png]   [image: Screenshot 2019-11-05 at 3.27.38 PM.png]

   - As we have renamed the menu from 'Drop Server' to 'Remove Server' we
   should also change the same for the below dialog when the user clicks on
   the menu:

                                 [image: Screenshot 2019-11-05 at 3.16.55
PM.png]

   - Please check the documentation as we renamed the menu, so we may need
   to change the docs.




On Tue, Nov 5, 2019 at 2:48 PM Rahul Shirsat <[email protected]>
wrote:

> Hi Hackers,
>
> Attached is the patch to move "Delete/Drop" menu option away from
> "Disconnect Servers" for server node.
>
> Additionally, I have renamed the "Delete/Drop" menu option to "Remove
> Server" for server node against issue RM3859.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation | Pune.
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
Screenshot 2019-11-05 at 3.27.22 PM.png (image/png, 23.3 KB) - not displayed
Screenshot 2019-11-05 at 3.27.38 PM.png (image/png, 52.1 KB) - not displayed
Screenshot 2019-11-05 at 3.16.55 PM.png (image/png, 31.9 KB) - not displayed
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.