Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Dave Page <[email protected]> Thu, 7 Nov 2019 14:26:46 +0000
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CA+OCxow-ZLN8sKETj5Bf7Y4gTWm+q7NtugfpG3_zt-KHzpvbJA@mail.gmail.com> |
On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[email protected]> wrote: > > On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[email protected]> > wrote: > >> Thanks, patch applied. >> >> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch with few more changes and corrections. >>> Kindly review. >>> >> > I've committed a couple of minor tweaks - one to remove a space, e.g. > > gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'), > > is now: > > gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'), > > And another change to fix the word wrapping in the README which was > totally different from the rest of the file. > > Thanks! > Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company