Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme
Aditya Toshniwal <[email protected]> Mon, 11 Nov 2019 12:31:03 +0530
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CAM9w-_=fuDGpPmFLg=w--LCF1jACMuWcqGb5BFX57AhE-Vm4xQ@mail.gmail.com> |
Hi Dave, On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[email protected]> wrote: > > > On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[email protected]> wrote: > >> >> On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi < >> [email protected]> wrote: >> >>> Thanks, patch applied. >>> >>> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the updated patch with few more changes and corrections. >>>> Kindly review. >>>> >>> >> I've committed a couple of minor tweaks - one to remove a space, e.g. >> >> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'), >> >> is now: >> >> gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'), >> >> And another change to fix the word wrapping in the README which was >> totally different from the rest of the file. >> >> Thanks! >> > > Oh, and do we need all the code in config.py? I really didn't even want a > config option in there to turn theming on or off (what's the point?), let > alone 20 new lines. > The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py. I'll reduce the code a bit. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"