Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

Rahul Shirsat <[email protected]> Sat, 23 Nov 2019 00:37:15 +0530
Newsgroups gmane.comp.db.postgresql.pgadmin.devel
Message-ID <CAKtn9dNz1ozbJWzJw_qVLx3QAxcNSjCCJWqB8HW3Qn5Hooz-pA@mail.gmail.com>
Akshay,

Please find the correction done in this updated patch based on your review
comments.

Regards,
Rahul Shirsat.

On Thu, Nov 21, 2019 at 1:08 PM Akshay Joshi <[email protected]>
wrote:

> Hi Rahul
>
> Some more review comments:
>
>    - Don't create new file test_view.json as I tested and committed the
>    old code.
>    - Remove hardcoded "oid: 17869" from JSON file.
>    - MSQL endpoints and file name missing in some test cases.
>    - Cover all the controls in create and alter as much as possible.
>
>
> On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Rahul
>>
>> Test cases failing on all EPAS servers. Please fix and send the patch
>> again.
>>
>> On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> I have attached the patch for RE-SQL/MSQL test cases for View as well as
>>> Materialized View.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
RM4696_v2.patch (application/octet-stream, 112.6 KB) - not displayed