Re: [pgAdmin][RM4633] Bad view in partitioned tables

--000000000000e90d2b059b7553b0
Content-Type: text/plain; charset="UTF-8"

On Mon, Jan 6, 2020 at 12:01 PM Khushboo Vashi <
[email protected]> wrote:

> Hi Akshay,
>
> On Fri, Jan 3, 2020 at 4:58 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Hi Hackers
>>
>> Attached is the patch to support the view part of the multilevel
>> partitions. Users can perform all the operations except creating the
>> partitions as a partitioned table. Users can create a partition table
>> separately and attach it as a partition of another partition table.
>>
> Multilevel partitions are now manageable through the tree view except
> creating a partition table of existing partition (which you already
> mentioned).
> One more problem that we already discussed that automatic tree refresh of
> the multilevel partitions is not working due to our structure which is
> going to be handled by the new RM.
>

    New RM https://redmine.postgresql.org/issues/5064 has been created.

>
> Some of the minor review comments.
> - _get_children_nodes name can be changed as it more like private method
> but we are using it outside of the class itself.
>

    Fixed.

> - Stats of partition table is not displayed, but I think that is not
> related to this patch, so can be fixed later.
>

   I have verified/confirmed that in the case of the Partitioned table,
Statistics is visible only for the child node. In the case of the
multilevel partitioned table, Statistics will only be available of the last
child node which we are showing, so it's not a bug.

>
> Thanks,
> Khushboo
>
>>
>> There are two problems mentioned in the RM. I have fixed the first one
>> and we won't fix the second problem as by design we decided to show
>> Partitions like Schema->Table->Partitions
>>
>> Please review it.
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

--000000000000e90d2b059b7553b0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"></div><br><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 6, 2020 at 12:01 PM Khushboo =
Vashi &lt;<a href=3D"mailto:[email protected]">khushboo.vashi=
@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex"><div dir=3D"ltr"><div>Hi Akshay,</div><br><div class=3D"gm=
ail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jan 3, 2020 at 4:5=
8 PM Akshay Joshi &lt;<a href=3D"mailto:[email protected]" targ=
et=3D"_blank">[email protected]</a>&gt; wrote:<br></div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers<div>=
<br></div><div>Attached=C2=A0is the patch to support the view part of the m=
ultilevel partitions. Users can perform all the operations except creating =
the partitions as a partitioned table. Users can create a partition table s=
eparately and attach it as a partition of another partition table.=C2=A0</d=
iv></div></blockquote><div><font color=3D"#000000">Multilevel partitions ar=
e now manageable through the tree view except creating a partition table of=
 existing partition (which you already mentioned).</font></div><div><font c=
olor=3D"#000000">One more problem that we already discussed that automatic =
tree refresh of the multilevel partitions is not working due to our structu=
re which is going to be handled by the new RM.</font></div></div></div></bl=
ockquote><div><br></div><div>=C2=A0 =C2=A0 New RM=C2=A0<a href=3D"https://r=
edmine.postgresql.org/issues/5064">https://redmine.postgresql.org/issues/50=
64</a>=C2=A0has been created.</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div><br></div><div>=
Some of the minor review comments.</div><div><font face=3D"arial, sans-seri=
f" color=3D"#000000">-=C2=A0_get_children_nodes name can be changed as it m=
ore like private method but we are using it outside of the class itself.</f=
ont></div></div></div></blockquote><div>=C2=A0 =C2=A0</div><div>=C2=A0 =C2=
=A0 Fixed.=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><di=
v dir=3D"ltr"><div class=3D"gmail_quote"><div><font face=3D"arial, sans-ser=
if" color=3D"#000000">- Stats of partition table is not displayed, but I th=
ink that is not related to this patch, so can be fixed later.</font></div><=
/div></div></blockquote><div><br></div><div>=C2=A0 =C2=A0I have verified/co=
nfirmed that in the case of the Partitioned table, Statistics is visible on=
ly for the child node. In the case of the multilevel partitioned table, Sta=
tistics will only be available of the last child node which we are showing,=
 so it&#39;s not a bug.</div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1=
ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div><font face=3D"arial, s=
ans-serif" color=3D"#000000"><br></font></div><div><font face=3D"arial, san=
s-serif" color=3D"#000000">Thanks,</font></div><div><font face=3D"arial, sa=
ns-serif" color=3D"#000000">Khushboo</font></div>





<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div><br=
></div><div>There are two problems mentioned in the RM. I have fixed the fi=
rst one and we won&#39;t fix the second problem as by design we decided to =
show Partitions like Schema-&gt;Table-&gt;Partitions</div><div><br></div><d=
iv>Please review it.</div><div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><di=
v><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">=
<div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family=
:arial,sans-serif;font-size:13px;border-collapse:collapse">Thanks &amp; Reg=
ards</span></b></font></div><div><font color=3D"#3333FF"><b><span style=3D"=
color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collaps=
e:collapse">Akshay Joshi</span></b></font></div><div><font color=3D"#3333FF=
"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size=
:13px;border-collapse:collapse">Sr. Software Architect<br></span></b></font=
></div><div><span style=3D"border-collapse:collapse"><font color=3D"#000000=
" face=3D"arial, sans-serif"><b>EnterpriseDB Software India Private Limited=
</b></font><br></span></div><div><b style=3D"color:rgb(51,51,255)"><span st=
yle=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-=
collapse:collapse">Mobile: +91 976-788-8246</span></b><br></div></div></div=
></div></div></div></div></div></div></div></div>
</blockquote></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"=
><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:=
13px;border-collapse:collapse">Thanks &amp; Regards</span></b></font></div>=
<div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family=
:arial,sans-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</sp=
an></b></font></div><div><font color=3D"#3333FF"><b><span style=3D"color:rg=
b(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:collap=
se">Sr. Software Architect<br></span></b></font></div><div><span style=3D"b=
order-collapse:collapse"><font color=3D"#000000" face=3D"arial, sans-serif"=
><b>EnterpriseDB Software India Private Limited</b></font><br></span></div>=
<div><b style=3D"color:rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font=
-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Mobile: +=
91 976-788-8246</span></b><br></div></div></div></div></div></div></div></d=
iv></div></div>

--000000000000e90d2b059b7553b0--