Re: pg_dump compatibility level / use create view instead of create table/rule

Tom Lane <[email protected]> Sat, 26 Oct 2019 17:18:09 -0400
Newsgroups gmane.comp.db.postgresql.sql,gmane.comp.db.postgresql.devel.general
Message-ID <[email protected]>
Andres Freund <[email protected]> writes:
> On 2019-10-10 11:20:14 -0400, Tom Lane wrote:
>> The reason we get "REPLICA IDENTITY NOTHING" is that a view's relreplident
>> is set to 'n' not 'd', which might not have been a great choice.

> Hm, yea. I wonder if we should add a REPLICA_IDENTITY_INVALID or such,
> for non relation relkinds?  I'm mildly inclined to think that setting it
> to REPLICA_IDENTITY_DEFAULT is at least as confusing as
> REPLICA_IDENTITY_DEFAULT...

Yeah, I'd be for that in HEAD probably.  But of course we can't change
the 9.x branches like that.

>> This is fixed in v10 and up thanks to d8c05aff5.  I was hesitant to
>> back-patch that at the time, but now that it's survived in the field
>> for a couple years, I think a good case could be made for doing so.

> +1

Just finishing up the back-patch now.

			regards, tom lane