Re: [PATCH] RRDCacheD: FETCH command: Remove call to "rrd_parsetime".
Tobias Oetiker <[email protected]>
| Newsgroups | gmane.comp.db.rrdtool.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Florian, Yesterday Florian Forster wrote: > From: Florian Forster <[email protected]> > > "rrd_parsetime" uses (many) global variables and is thus not > thread-safe. Using it in the FETCH command reproducably segfaults the > caching daemon. > > This replacement will only work with "simple" integers, i. e. times > specified as "1272470594" (sometime on April 28th) or "-3600" (one hour > ago). > > A more thorough fix would be to rewrite "rrd_parsetime" in a thread-safe > manner, but unfortunately I don't have the time right now. yep! cheers tobi -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch [email protected] ++41 62 775 9902 / sb: -9900