Re: Discuss regarding Ticket 263

Hi Jean,

May 25 Jean-Edouard Babin wrote:

> So, I removed the never flags and improved the behavior of time_clean
>
> On Tue, May 25, 2010 at 9:23 AM, Alex van den Bogaerdt
> <[email protected]> wrote:
> > ----- Original Message -----
> > From: "Tobias Oetiker" <[email protected]>
> > To: "Alex van den Bogaerdt" <[email protected]>
> > Cc: <[email protected]>
> > Sent: Tuesday, May 25, 2010 8:32 AM
> > Subject: Re: [rrd-developers] Discuss regarding Ticket 263
> >
> >> I agree that 0 could serve as a value for undefined since rrdtool
> >> curently does not let you use dates before 1980 when creating an
> >> rrd (this is an arbitrary choice in the code and could be removed
> >> with a very short patch). In 1.5 we shuld be able todo this at
> >> least for platforms using 64bit dates.
> >>
> >> In general I think it is a sub optimal solution to use inband
> >> signaling ... here we can get proper out of band signaling without
> >> any disadvantage ... so I welcome this.
> >
> > By all means, do it, like I said: just my 2ct :)
> >
> > I do not remember it very well, it has been years ago, but just know that I
> > did the work with 0 actually meaning false. Please make sure not to overlook
> > any tests that may be in the code, easily overlooked and then you have a
> > bug.


I actually quite like the never flag, since in view of time
switching to 64bits I would rather have no special cases in the
'value' stream ...

I have merged a mix between v1 and v2 of your patches to trunk

cheers and thanks
tobi

> >
> > cheers,
> > Alex
> >
> > _______________________________________________
> > rrd-developers mailing list
> > [email protected]
> > https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers
> >
>
>
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch [email protected] ++41 62 775 9902 / sb: -9900