Re: [PATCH] rrdcached: Let the -s, -m and -P options affect the default socket as well.
Bernard Li <[email protected]>
| Newsgroups | gmane.comp.db.rrdtool.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Sebastian: On Tue, Jul 13, 2010 at 2:33 PM, Sebastian Harl <[email protected]> wrote: > Sure, it's attached to this E-mail. Thanks, the patch works now. I've found an issue though -- it looks like the permissions of the default socket file is different from before: [1.4.3] s--------- 1 root root 0 Jul 13 15:40 /tmp/rrdcached.sock [1.4 branch + patch] srwxr-xr-x 1 root root 0 Jul 13 15:40 /tmp/rrdcached.sock Otherwise, from my brief testing it seems to work as expected. BTW, right now if you specify a socket via -l *and* have -m, -s or -P after it, the daemon will merrily run. I think this should be considered a syntax error since it's ambiguous. Perhaps another way to deter this is to change the ordering of the option displayed in the manpages/help. P.S. Not sure where the issue is but it seems that the replies you sent back to the list have my email address as one of the recipient. This is normally fine, however some how Gmail interpreted it as a reply-to and thus when I reply back to your email it always tag on my email address. Do you have any idea why? Thanks, Bernard