Re: rrdcached use corrupting RRD files (trunk)
Steve Shipway <[email protected]>
| Newsgroups | gmane.comp.db.rrdtool.devel |
|---|---|
| Message-ID | <28E447343A85354483BCF7C3E9D5EAA5149A3C21@uxcn10-1.UoA.auckland.ac.nz> |
Many thanks for your work here, I hate memory leaks :(. I liberated this bit of code from the rrd_info_r function; I can't check from here but I suspect the same leak is there, though I didn't spot it - but it wouldn't affect things there as its not called from the daemon. I've been trying to make valgrind work for me yesterday without success... I'll implement this immediately and see if I get the same issues recurring (in which case theres yet another one to find in there somethere...) Steve Steve Shipway University of Auckland ITS UNIX Systems Design Lead [email protected] Ph: +64 9 373 7599 ext 86487 ________________________________________ From: [email protected] [[email protected]] on behalf of kevin brintnall [[email protected]] Sent: Saturday, 23 October 2010 1:34 a.m. To: [email protected] Subject: Re: [rrd-developers] rrdcached use corrupting RRD files (trunk) Steve, I think this fixes the memory leak in "INFO". Could you please test and let me know. I cleaned up the loop a little too. -kb -