Re: [PATCH] fix for an endless loop

Tobias Oetiker <[email protected]>
Newsgroups gmane.comp.db.rrdtool.devel
Message-ID <[email protected]>
Hi Peter,

thanks for your patch ...

cheers
tobi

Oct 29 Peter Stamfest wrote:

> Hello,
>
> Here is a patch that fixes a serious endless loop problem on 32 bit
> architectures near the timestamp 2^31 (oh yes - y2k038 is showing its ugly
> face) when using the graph command(s). Once the endtime of a graph is
> above the mentioned timestamp, mktime always returns -1 (and correctly
> so), causing some loops to loop forever. The patch fixes this, causing
> some strange output, but there is no other sane way to handle this (expect
> by switching to a 64 bit platform).
>
> The patch has seen only light testing, but because it merely handles an
> error case that usually triggers rarely, its impact should not be too
> high. That said: I did not test it for daylight saving time switchovers.
>
> Sorry for not inlining the patch - the mailer I use these days has its
> problems with formatting.
>
> peter
>
>
>

-- 
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland
http://it.oetiker.ch [email protected] ++41 62 775 9902 / sb: -9900
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.