Re: rrdcached: path sanitizer
Tobias Oetiker <[email protected]> Thu, 6 Dec 2012 06:39:54 +0100 (CET)
| Newsgroups | gmane.comp.db.rrdtool.devel |
|---|---|
| Message-ID | <[email protected]> |
Today Kiss Gabor (Bitman) wrote: > > > realpath() expands all symbolic links and resolves references to > > > /./, > > > This is going to cause a LOT of stat() calls: O(commands * average dir > > depth) > > > > I see your point, but it's probably better to do trivial string > > manipulations that don't hit the filesystem. > > The whole point of rrdcached is to defer and collate I/O. > > You are absolutely right. Originally I wanted a simple character > copy function but suddenly I found realpath() and I was too happy > to think over what happens to symlinks. Sorry for the noise. for the rrdtool future, make sure to check out and provide your input on https://github.com/oetiker/rrdtool-2.x cheers tobi > > Gabor > > -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch [email protected] ++41 62 775 9902 / sb: -9900