Re: RFC: [PATCH] Portability by avoiding PATH_MAX
Svante Signell <[email protected]> Thu, 08 May 2014 09:58:27 +0200
| Newsgroups | gmane.comp.db.rrdtool.devel |
|---|---|
| Organization | Home |
| Message-ID | <[email protected]> |
On Thu, 2014-05-08 at 09:15 +0200, Tobias Oetiker wrote: > Today Svante Signell wrote: ... > > Additionally, I normally get my patches reviewed by the Hurd developers, > > and I can do this for the PATH_MAX patches too. It is considered sloppy > > coding to use PATH_MAX, see > > https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html > > and > > http://insanecoding.blogspot.se/2007/11/pathmax-simply-isnt.html > > > > In Debian there is an increasing number of people adhering to this too. > > > > You either use a fixed number of elements when allocating an array on > > the stack or malloc/free for the heap. I think it is worthy the effort > > to get things right once and for all. > > ok :-) how about a pull request ? Hi, the link you gave did only show how to download a pull request not how to create one? And do you have to create a pull request using github? I have to read some more before being able to create one.