Re: always poll, even without poll(2)
Frediano Ziglio <[email protected]>
| Newsgroups | gmane.comp.db.tds.freetds |
|---|---|
| Message-ID | <1230999751.7239.10.camel@freddy> |
Il giorno mar, 30/12/2008 alle 01.34 -0500, James K. Lowden ha scritto: > Frediano Ziglio wrote: > > What do you think about > ... > > +#if defined(WIN32) > > + /* Win32 cares about the number of descriptors, not the > > highest one. */ + ++maxfd; > > +#else > > if (p->fd > maxfd) > > maxfd = p->fd; > > +#endif > > It's a very close call. Your way is slightly more efficient (probably) > and mine relies a little less on the preprocessor. But yours might be a > little clearer, finally, because maxfd isn't calculated one way first and > later overridden. Feel free to change it if you like. > Committed. Have an happy new year Frediano Ziglio