Re: Socket Error on Win2008 Enterprise & Windows Vista Enterprise

On Tue, Nov 24, 2009 at 01:04:58AM -0500, Paul Thurston wrote:
> 
> I found the bug in the code. 
> 
> The Windows build (using VC9) is not calling INITSOCKET() which should be
> set to _tds_socket_init for WIN32.

Well done.  That bug existed in the old codebase you're working with.  For about a year now tds_alloc_context() has called WSAStartup(), so socket(2) cannot fail, at least not for that reason.  

> -----Original Message-----
> From: James K. Lowden
> Sent: Tuesday, November 24, 2009 12:54 AM
> 
> Memo to file: When compiling for Win32, it would be nice to call
> FormatMessage() to get something printable for the log.  

File to memo: Good idea, already done, cf. tds_prwsaerror(). 

--jkl