Re: [PATCH] tds_get_locale() update (was Re: SQL Server version and TDS Version)

On Sun, May 23, 2010 at 4:13 PM, Craig A. Berry <[email protected]> wrote:
>
> There is no checking to see if the client charset is already set in the
> locale structure, so in effect, locale->client_charset is an appendage that
> is never used for anything.  It's already been orphaned so we might as well
> deprecate it.
>
> So the next step is to move the nl_langinfo(CODESET) call out of
> tds_alloc_locale() and into tds_alloc_connection(), replacing the hard-wired
> ISO-8859-1 with what we get by interrogating the locale.
>
> But I think that needs more discussion because anyone with a misconfigured
> locale will suddenly not be able to construct a valid login packet;
> basically we'll be doing at the library level what tsql has been doing for a
> long time at the application level, and which generated the problem report
> that led us down this road in the first place.

Craig: should I pull the latest source to see if things work?  Or is
it still work in progress?

Thanks so much!
Vinh
_______________________________________________
FreeTDS mailing list
[email protected]
http://lists.ibiblio.org/mailman/listinfo/freetds