setlocale not that ok...

Frediano Ziglio <[email protected]> Mon, 28 Jun 2010 16:51:04 +0200

Newsgroups	gmane.comp.db.tds.freetds
Message-ID	<[email protected]>

Hi,
  I think that calling setlocale in a library with locale != NULL is
mainly a bad idea. Doing setlocale change global settings that should
be done by the application not by a library. Setting locale changes
subtle things like sprintf witch application should be prepared to
handle.

I think we should remove setlocale(LC_ALL, "") in src/tds/mem.c and
src/tds/locale.c. Applications like tsql, bsql and similars should
call setlocale by themselves.

Regards
  Frediano Ziglio