Re: [ freetds-Patches-3060920 ] Improvements for db-lib

LacaK <[email protected]>
Newsgroups gmane.comp.db.tds.freetds
Message-ID <[email protected]>
>> Thanks (I see change in CVS), but on web page is it not modified ... will
>> it be refreshed automaticaly later ?
>>
>> One more question. I see, that functions are documented in source code, and
>> Doxygen is used to generate documentation.
>> http://www.freetds.org/reference/a00274.html
>>
>> So should I write documentation for dbiscount() into dblib.c? (or will it
>> do somebody else? ;-))
>>
>> L.
>>
>>
>>     
> The job is fully open :)
>
> Nobody is in charge for stuff like this.
>   
So I send patch, which adds "documentation comments". I hope it is ok ;-)

-Laco.

_______________________________________________
FreeTDS mailing list
[email protected]
http://lists.ibiblio.org/mailman/listinfo/freetds
dblib.c.diff (text/plain, 1.4 KB)
--- f:\tmp\dblib.c.ori	Wed Sep 15 05:55:44 2010
+++ f:\tmp\dblib.c	Thu Sep 16 09:55:24 2010
@@ -2699,17 +2699,15 @@ dbanullbind(DBPROCESS * dbproc, int comp
 	return SUCCEED;
 }
 
-/** \internal
+/**
  * \ingroup dblib_internal
- * \brief Get count of rows processed
- * 
+ * \brief Indicates whether or not the count returned by dbcount is real (Microsoft-compatibility feature).
  * 
  * \param dbproc contains all information needed by db-lib to manage communications with the server.
- * \returns 
- * 	- for insert/update/delete, count of rows affected.
- * 	- for select, count of rows returned, after all rows have been fetched.  
- * \sa DBCOUNT(), dbnextrow(), dbresults().
+ * \returns TRUE if the count returned by dbcount is real or FALSE if the count returned by dbcount is not real. 
+ * \sa DBCOUNT(), dbcount().
  */
+
 BOOL
 dbiscount(DBPROCESS * dbproc)
 {
@@ -2718,6 +2716,18 @@ dbiscount(DBPROCESS * dbproc)
 
 	return dbproc->tds_socket && dbproc->tds_socket->rows_affected != TDS_NO_COUNT;
 }
+
+/** \internal
+ * \ingroup dblib_internal
+ * \brief Get count of rows processed
+ * 
+ * 
+ * \param dbproc contains all information needed by db-lib to manage communications with the server.
+ * \returns 
+ * 	- for insert/update/delete, count of rows affected.
+ * 	- for select, count of rows returned, after all rows have been fetched.  
+ * \sa DBCOUNT(), dbnextrow(), dbresults().
+ */
 
 DBINT
 dbcount(DBPROCESS * dbproc)
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.