Re: Truncation of string values to 80 characters using placeholders and MSSQL

As others have mentioned, the bug appears to be caused in src/tds/query.c and can
be largely fixed with this patch:

--- freetds-0.91RC2-orig/src/tds/query.c        2011-03-30
+++ freetds-0.91RC2-patch_truncation/src/tds/query.c    2011-05-05
@@ -799,7 +799,7 @@
                        if (tds_get_column_declaration(tds, params->columns[i], \
declaration + strlen(declaration)) == TDS_FAIL)
                                goto Cleanup;
                } else {
-                       strcat(declaration, "varchar(80)");
+                       strcat(declaration, "varchar(4000)");
                }

                /* convert it to ucs2 and append */

However, I'm not sure that every server accepts varchar(4000) as a column type,
and some may allow even larger varchars (so that the fixed code is still buggy
if the string is longer than 4000 chars).  I'd be interested in your thoughts on
the right way to fix it.

-- 
Ed Avis <[email protected]>