Re: bug fixes
Frediano Ziglio <[email protected]>
| Newsgroups | gmane.comp.db.tds.freetds |
|---|---|
| Message-ID | <[email protected]> |
> >> - bcp queryout broke recently: Fix broken code in bulk.c that attempted >> to get just the metadata using "select * from %s where 0 = 1". >> Guess what? %s is not the table name in queryout... Fix it properly >> using FMTONLY like it was done in freebcp.c. Again this code is >> duplicated from freebcp.c and we probably don't need to do it >> there anymore, and we should move the functionality to the library. >> > > mmm.... I discovered that only FreeTDS supports DB_QUERYOUT !!! > Sybase/MS only implement DB_IN/DB_OUT... I'd ask how they implement > queryout... perhaps with a normal processing :) > > Now... remove DB_QUERYOUT and fix queryout on our freebcp utility ?? > Or implement correctly DB_QUERYOUT... hard to say... > What does you mean by "recently" ?? > > If stuff worked on 0.82 fo maintain compatibility I would say support > DB_QUERYOUT. If not I would say remove DB_QUERYOUT !! > > Bill, James, what do you think ?? > This http://gitorious.org/freetds/freetds/commit/c1ce798aedb70c6e9988dd0f2061d1aa87fdd770 should be the commit :( 2 years ago and our tests didn't catch the problem... really bad! I wrote tds_bcp_init not to be called with direction != DB_IN, i didn't write an assert for this. Frediano _______________________________________________ FreeTDS mailing list [email protected] http://lists.ibiblio.org/mailman/listinfo/freetds