Re: Encrypted connection

Frediano Ziglio <[email protected]>
Newsgroups gmane.comp.db.tds.freetds
Message-ID <CAHt6W4enK77NodnYFamrasBKgstcc=v8JQL6xFQpG9kL_Y2nAg@mail.gmail.com>
I found some time to merge your request. I just did some additional
style changes (see
https://gitorious.org/freetds/mars-freetds/commits/7da9b46a73ab638776c140a9c4570280b9989f5a).

I would merge but I would prefer a nicer set of changesets or better a
single one.

As you are the main author do you mind squash them all in another
branch and send the request (or the patch if you prefer) ?

I'm actually executing our tests with your changes bu I don't think
there will be problems (if my configuration is ok :) )

Frediano


2013/10/24 Marc Abramowitz <[email protected]>:
> Freddy,
>
> I just submitted a merge request to your config_error branch with James's
> suggestion to flip the boolean and a few other tweaks centered on making it
> more apparent to the user what went wrong. Check it out when you get a
> chance:
>
> https://gitorious.org/freetds/mars-freetds/merge_requests/1
>
> Marc
>
>
> On Tue, Oct 22, 2013 at 7:54 PM, James K. Lowden <[email protected]>wrote:
>
>> On Tue, 22 Oct 2013 21:13:30 +0100
>> Frediano Ziglio <[email protected]> wrote:
>>
>> > +    unsigned int invalid_configuration:1;
>>
>> Recommend
>>
>>         unsigned int valid_configuration:1;
>>
>> instead.  I don't like missing no double negative flags reset.
>> Confusing they are when values set be.
>>
>> --jkl
>> _______________________________________________
>> FreeTDS mailing list
>> [email protected]
>> http://lists.ibiblio.org/mailman/listinfo/freetds
>>
> _______________________________________________
> FreeTDS mailing list
> [email protected]
> http://lists.ibiblio.org/mailman/listinfo/freetds
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.