Re: Way to get connection params on failure?

Hi,
  Dstr fields should not be acccessed directly. Are you sure buffer is
freed?

Beside this patch looks good. Perhaps should be moved in libtds so all
layers will use this code.

About dynamic parameters values should be controlled as are only errors
from our library, not from server

Frediano
Il 06/gen/2014 19:08 "Marc Abramowitz" <[email protected]> ha scritto:

> On Sun, Jan 5, 2014 at 11:32 AM, Frediano Ziglio <[email protected]>
> wrote:
>
> > The problem of your implementation is that TDSECONN is passed by
> > libTDS and not all libraries add the required parameter so you can
> > have a not formatted string in other libraries.
> >
> > Mixing normal string and string with format looks a bit security suspect
> > to me.
> >
>
> Yeah, that smelled a little funny to me too.
>
> I updated my PR so that dbperror itself appends the server_name, if
> available, to the error message. So no need to pass it into dbperror.
>
> https://gitorious.org/freetds/freetds/merge_requests/24/diffs
>
> Hopefully, that's better.
>
> Marc
> _______________________________________________
> FreeTDS mailing list
> [email protected]
> http://lists.ibiblio.org/mailman/listinfo/freetds
>