Re: alloca() usage, building master pre-0.95 on Windows
Frediano Ziglio <[email protected]>
| Newsgroups | gmane.comp.db.tds.freetds |
|---|---|
| Message-ID | <CAHt6W4cydqmSvU-npJB-i4Vp0DYgHGkDBYcvGex94Mfhpoh23w@mail.gmail.com> |
2015-05-02 22:45 GMT+01:00 Ramiro Morales <[email protected]>: > On Sat, May 2, 2015 at 6:14 PM, Ramiro Morales <[email protected]> wrote: > >> My question is: What would be the best path to fix this?: >> >> 1. Modify token.c to use another function instead of alloca, e.g. >> malloc() which is widely used elsewhere in the code base? >> 2. Patch token.c so it conditionally #include <malloc.h> if Visual C >> is detected? >> 3. Another option? > > Forgot to say I tested option 2 successfully and this the last > remaining issue to get master to build on Windows. > Well.. a git pull should be enough :) As is not a standard header I add check on configure scripts and included conditionally. Frediano