Re: defncopy for old servers
Frediano Ziglio <[email protected]>
| Newsgroups | gmane.comp.db.tds.freetds |
|---|---|
| Message-ID | <CAHt6W4cV4wQL=HW+8phzmeNXRRZB+tE+jPDEubjrcUzznhcs7g@mail.gmail.com> |
That's why I applied it :-) Frediano 2016-04-15 7:32 GMT+01:00 <[email protected]>: > I can't see why we shouldn't make this change. This syntax works with ASE 16 and SQL Server 20114 and I'm not aware of any plans to remove support for it in the future..... if nothing else there are too many programs out there which use this syntax. > > Cheers, > > Matthew. > > April 15 2016 1:24 AM, "John Kendall" <[email protected]> wrote: >>>> The defncopy app has one bit of SQL in it that uses an ANSI join. This makes it fail on pre-ASE >>>> 12.0. To get it to work with my old servers i need to patch it each time I download the latest >>>> FreeTDS. >>>> >>>> Since the SQL89 inner joins are still considered fine, I was wondering if this patch could be >>>> applied. Then it will work for all servers out-of-the-box. >>> >>> Why did you remove the 'as' keyword? >>> >>> christos >> >> The 'as' keyword doesn't work with my older servers; and leaving out the 'as' keyword works with >> current servers. >> >> John >> >>>> *** defncopy.c-orig Mon Feb 29 12:00:00 2016 >>>> --- defncopy.c Wed Apr 13 16:14:57 2016 >>>> *************** >>>> *** 211,220 **** >>>> static const char query[] = " select cast(c.text as text)" >>>> #endif /* MicrosoftsDbLib */ >>>> ", number " >>>> ! " from syscomments as c" >>>> ! " join sysobjects as o" >>>> ! " on o.id = c.id" >>>> ! " where o.name = '%s'" >>>> " and o.uid = user_id('%s')" >>>> " and o.type not in ('U', 'S')" /* no user or system tables */ >>>> " order by c.number, c.colid" >>>> --- 211,220 ---- >>>> static const char query[] = " select cast(c.text as text)" >>>> #endif /* MicrosoftsDbLib */ >>>> ", number " >>>> ! " from syscomments c," >>>> ! " sysobjects o" >>>> ! " where o.id = c.id" >>>> ! " and o.name = '%s'" >>>> " and o.uid = user_id('%s')" >>>> " and o.type not in ('U', 'S')" /* no user or system tables */ >>>> " order by c.number, c.colid" >>>> >>>> Thanks for considering this. >>>> >>>> John >> >> _______________________________________________ >> FreeTDS mailing list >> [email protected] >> http://lists.ibiblio.org/mailman/listinfo/freetds > _______________________________________________ > FreeTDS mailing list > [email protected] > http://lists.ibiblio.org/mailman/listinfo/freetds