Re: Another defncopy patch - check dbopen results
Frediano Ziglio <[email protected]>
| Newsgroups | gmane.comp.db.tds.freetds |
|---|---|
| Message-ID | <CAHt6W4dM60o-zKu48EGOfwFvnci6YYGvkeu3+VJMKfhSRyCLxg@mail.gmail.com> |
2016-06-16 21:20 GMT+01:00 Nem W Schlecht <[email protected]>: > I have another defncopy patch to fix another issue. The results from > dbopen() are just checked with an assert() call. Thus, if I type in > the wrong database name, username, whatever, I get a core dump that I > have to clean up from a typo on my part. What do you all think of a > quick check/message/exit, similar to what happens with tsql? > > Patch attached. Just checks to see if dbproc has a value. If not, > prints an error message and exit(1)s. Otherwise, continues on. > > I deal with a lot of servers and a lot of usernames/passwords, so this > one hits me fairly often. > > > -- > Nem W Schlecht > "Perl did the magic. I just waved the wand." > Merged, thanks