Re: defncopy core dump

Thanks John!  The weird thing is that that is *my* patch!  (At least I
reported the bug).  I'm not sure why the equal sign was moved, though.

On Wed, May 24, 2017 at 12:30 PM, John Kendall <[email protected]> wrote:
> Hi, Nem.
> It looks like the change to lines 577 and 578 were made back in June 2016 (before mine).
>
> https://github.com/FreeTDS/freetds/commit/a67dc7502bf75d56c342f7af7b5d7e4dba826000
>
> Fixing this issue shouldn't affect mine.
>
> John
>
>
>
> On May 2, 2017, at 6:12 PM, Nem W Schlecht <[email protected]> wrote:
>
>> Hello all,
>>
>> Sorry, but it's been awhile since I compiled freetds (version 1.00.1
>> has been working just fine for me).
>>
>> My old favorite tool, defncopy, is core dumping again. :)
>>
>> Looks like these lines here:
>>
>> 577,578
>>        if (sizeof(sql_text) <= dbcollen(dbproc, ctext) ) {
>>            assert(sizeof(sql_text) > dbcollen(dbproc, ctext));
>>
>> The equal sign was moved from the line 578 to 577.  This causes
>> defncopy to core dump for me (Cygwin on Windows).
>>
>> If I move the equal sign back to the way it was in my older copy of
>> code (1.00.1), then defncopy works perfectly again:
>>
>> 577,578
>>        if (sizeof(sql_text) < dbcollen(dbproc, ctext) ) {
>>            assert(sizeof(sql_text) >= dbcollen(dbproc, ctext));
>>
>> I see in the Changelog a change made by John Kendall on Aug 25th
>> mentioning a fix for defncopy for ASE servers.  Not sure how to get
>> things to work for both systems.
>>
>> Thanks all! :)
>>
>> --
>> Nem W Schlecht
>> "Perl did the magic. I just waved the wand."
>> _______________________________________________
>> FreeTDS mailing list
>> [email protected]
>> https://url.serverdata.net/?aYRdQGi3vXnuQJoWNSo02MmxBZ2G78s3rT1G4ZsYjcsqm3Z4xKVzDM1akvRgp9GkOw4EtE219pjbkUFsmgT8ImQ~~
>
> _______________________________________________
> FreeTDS mailing list
> [email protected]
> http://mailman1.ibiblio.org/mailman/listinfo/freetds



-- 
Nem W Schlecht
"Perl did the magic. I just waved the wand."