Re: Reintegrating years of local FreeTDS changes

Responding inline.

Sebastien FLAESCH <[email protected]> writes:

> Thanks for the link!

Thanks for the review!  These warnings, however, are all preexisting --
only one (from tds_bcp_send_record in src/tds/bulk.c) pertains to a
function I touched at all, and even then I left the relevant portions
alone.  That said, I could of course still tweak my big warnings-cleanup
commit to include fixes, and will be happy to do so if I have to revise
any other commits anyway.

> bulk.c: In function 'tds_bcp_send_record':
> bulk.c:622:23: warning: 'bitpos' may be used uninitialized in this function [-Wmaybe-uninitialized]

By my reading of this code, this warning is spurious, though I suppose
it would be cheap enough to give bitpos a formal initializer to shut the
compiler up. ;-)

-- 
Aaron Ucko <ucko at ncbi>, NCBI C++ Toolkit core development group