Re: FreeTDS 1.1 Release Candidate 1 - compilation warnings

Hi all,

Compiling with gcc 8.2.0, I get following warnings:

...

make[4]: Entering directory '/opt3/dbs/tds/sources/freetds-1.1rc1/src/tds'
   CC       mem.lo
   CC       token.lo
   CC       util.lo
   CC       login.lo
   CC       read.lo
read.c: In function 'read_and_convert':
read.c:290:6: warning: variable 'res' set but not used [-Wunused-but-set-variable]
   int res;
       ^~~
   CC       write.lo
write.c: In function 'tds_put_string':
write.c:95:6: warning: variable 'res' set but not used [-Wunused-but-set-variable]
   int res;
       ^~~
   CC       convert.lo
   CC       numeric.lo
   CC       config.lo
   CC       query.lo
query.c: In function 'tds_submit_execdirect':
query.c:1383:11: warning: unused variable 'ret' [-Wunused-variable]
     TDSRET ret;
            ^~~

...

   CC       random.lo
random.c: In function 'tds_random_buffer':
random.c:59:2: warning: 'RAND_pseudo_bytes' is deprecated [-Wdeprecated-declarations]
   if (RAND_pseudo_bytes(out, len) >= 0)
   ^~
In file included from /usr/include/openssl/e_os2.h:13,
                  from /usr/include/openssl/ossl_typ.h:19,
                  from /usr/include/openssl/rand.h:14,
                  from random.c:36:
/usr/include/openssl/rand.h:47:1: note: declared here
  DEPRECATEDIN_1_1_0(int RAND_pseudo_bytes(unsigned char *buf, int num))
  ^~~~~~~~~~~~~~~~~~
   CC       sec_negotiate.lo
   CC       challenge.lo
   CC       gssapi.lo
   CCLD     libtds.la
ar: `u' modifier ignored since `D' is the default (see `U')
make[4]: Leaving directory '/opt3/dbs/tds/sources/freetds-1.1rc1/src/tds'


...


make[3]: Entering directory '/opt3/dbs/tds/sources/freetds-1.1rc1/src/ctlib'
   CC       ct.lo
ct.c: In function '_ct_get_client_type':
ct.c:1950:2: warning: enumeration value 'SYBNTEXT' not handled in switch [-Wswitch]
   switch (col->column_type) {
   ^~~~~~
ct.c:1950:2: warning: enumeration value 'SYBVOID' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBNVARCHAR' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'XSYBCHAR' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'XSYBVARCHAR' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'XSYBNVARCHAR' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'XSYBNCHAR' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'XSYBVARBINARY' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'XSYBBINARY' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBVARIANT' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBMSUDT' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBMSXML' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBDATEN' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYB5INT8' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBINTERVAL' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBLONGCHAR' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBSENSITIVITY' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBSINT1' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBTIMEN' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBUINTN' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBUNITEXT' not handled in switch [-Wswitch]
ct.c:1950:2: warning: enumeration value 'SYBXML' not handled in switch [-Wswitch]


...

make[3]: Entering directory '/opt3/dbs/tds/sources/freetds-1.1rc1/src/dblib'
   CC       dblib.lo
dblib.c:432:24: warning: 'null_BINARY' defined but not used [-Wunused-const-variable=]
  static const DBBINARY  null_BINARY = 0;
                         ^~~~~~~~~~~
   CC       dbutil.lo
   CC       rpc.lo
   CC       bcp.lo
bcp.c: In function 'bcp_readfmt':
bcp.c:1630:8: warning: variable 'lf_version' set but not used [-Wunused-but-set-variable]
   float lf_version = 0.0;
         ^~~~~~~~~~
   CC       xact.lo
   CC       dbpivot.lo
dbpivot.c: In function 'col_equal':
dbpivot.c:137:2: warning: enumeration value 'SYBNVARCHAR' not handled in switch [-Wswitch]
   switch(pc1->type) {
   ^~~~~~
dbpivot.c:137:2: warning: enumeration value 'SYBINT8' not handled in switch [-Wswitch]
dbpivot.c:137:2: warning: enumeration value 'XSYBCHAR' not handled in switch [-Wswitch]
dbpivot.c:137:2: warning: enumeration value 'XSYBVARCHAR' not handled in switch [-Wswitch]
dbpivot.c:137:2: warning: enumeration value 'XSYBNVARCHAR' not handled in switch [-Wswitch]
...


dbpivot.c:182:2: warning: enumeration value 'SYBNVARCHAR' not handled in switch [-Wswitch]
   switch(pcol->type) {
   ^~~~~~
dbpivot.c:182:2: warning: enumeration value 'SYBINT8' not handled in switch [-Wswitch]
dbpivot.c:182:2: warning: enumeration value 'XSYBCHAR' not handled in switch [-Wswitch]
dbpivot.c:182:2: warning: enumeration value 'XSYBVARCHAR' not handled in switch [-Wswitch]

...

defncopy.c: In function 'get_login':
defncopy.c:669:6: warning: variable 'fdomain' set but not used [-Wunused-but-set-variable]
   int fdomain = TRUE;
       ^~~~~~~
   CCLD     defncopy
   CC       datacopy.o

...

Seb