DDD, pydb branch

Peter Wainwright <[email protected]>
Newsgroups gmane.comp.debugging.ddd.general
Message-ID <[email protected]>
I've merged the pydb branch to my own copy of the DDD trunk (it applied
very cleanly), and I'm trying it out now.  I hope soon to be able to
merge it into the trunk on Savannah, and release 3.3.12-rc1...

I did run across an issue: When starting DDD in stacked mode with gdb as
inferior debugger, the machine code window always appears, regardless of
the setting Ddd*disassemble.

It looks like there is "&&" where there should be "||" in a few places,
as per this patch:

If you have no objections I'll commit this to the pydb branch.

Regards,
Peter

_______________________________________________
ddd mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/ddd
ddd_pydb_disassembly_visibility.patch (text/x-patch, 647 B)
Index: ddd/ddd.C
===================================================================
--- ddd/ddd.C	(revision 7931)
+++ ddd/ddd.C	(revision 7932)
@@ -4018,11 +4018,11 @@
 	// We don't need the source window, since we're invoked by Emacs.
 	gdbCloseSourceWindowCB(gdb_w, 0, 0);
 
-	if (!app_data.disassemble && !gdb->has_disassembly())
+	if (!app_data.disassemble || !gdb->has_disassembly())
 	    gdbCloseToolWindowCB(gdb_w, 0, 0);
     }
 
-    if (!app_data.disassemble && !gdb->has_disassembly())
+    if (!app_data.disassemble || !gdb->has_disassembly())
     {
 	// We don't disassemble.
 	gdbCloseCodeWindowCB(gdb_w, 0, 0);
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.