Re: [PATCH] Rotate ChangeLog, fix build issues

I am not sure, bug I got:
gcc -g -O2   -I. -I../../src/gdb -I../../src/gdb/common
-I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\""
-DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
-I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd
-I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber
-I../../src/gdb/../libdecnumber  -I../../src/gdb/gnulib -Ignulib
-DMI_OUT=1 -DTUI=1  -DGDBTK -I/usr/include/python2.6
-I/usr/include/python2.6 -Wall -Wdeclaration-after-statement
-Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused
-Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts
-Werror -c -o gdbtk-bp.o -MT gdbtk-bp.o -MMD -MP -MF
.deps/gdbtk-bp.Tpo -I../../src/gdb/../libgui/src
-I/home/teawater/gdb/cvs/src/tcl/generic
-I/home/teawater/gdb/cvs/src/tk/generic
-DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\"
-DSRC_DIR=\"/home/teawater/gdb/cvs/src/gdb\"
../../src/gdb/gdbtk/generic/gdbtk-bp.c
../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'tracepoint_exists':
../../src/gdb/gdbtk/generic/gdbtk-bp.c:834: error: too many arguments
to function 'decode_line_1'
make[2]: *** [gdbtk-bp.o] Error 1
make[2]: Leaving directory `/home/teawater/gdb/cvs/ba/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/home/teawater/gdb/cvs/ba'
make: *** [all] Error 2


struct symtabs_and_lines
decode_line_1 (char **argptr, int funfirstline, struct symtab *default_symtab,
	       int default_line, struct linespec_result *canonical)

Thanks,
Hui

On Sat, Apr 9, 2011 at 07:35, Keith Seitz <[email protected]> wrote:
> Hi,
>
> Now that I have something to commit, it is time to rotate the ChangeLog for
> the year...
>
> I've committed the attached patch, which should fix all the build problems
> that have been reported. Additionally, this should fix a crashing problem
> that I discovered (some time ago) in the register window.
>
> If there are any problems, please let me know.
>
> Keith
>
> ChangeLog
> 2011-04-08  Keith Seitz  <[email protected]>
>
>        * generic/gdbtk-bp.c (tracepoint_exists): Update for
>        decode_line_1 API change.
>        * generic/gdbtk-cmds.c (gdb_eval): Use comman_val_print
>        instead of val_print.
>        (gdb_get_line_command): Update for decode_line_1 API
>        changes.
>        (gdb_get_file_command): Likewise.
>        (gdb_get_function_command): Likewise.
>        * generic/gdbtk-register.c (get_register_types): Use
>        get_frame_register_value instead of frame_register.
>        (get_register): Pass valid VALUE to val_print.
>        Consolidate calls to get_current_gdbarch.
>        * generic/gdbtk-stack.c (gdb_get_vars_command): Update
>        for decode_line_1 API change.
>