Re: Recent tracepoint changes in gdb

On 11/10/2012 09:50 AM, Keith Seitz wrote:
> On 11/05/2012 07:37 AM, Keith Seitz wrote:
>> Thanks for pointing this out, I will work on a patch.
>
> Here is the patch. Let me know if there are any further difficulties.

Gah! And there was a logic bug in that patch. This patch fixes that.

Keith

ChangeLog
2012-11-10  Keith Seitz  <[email protected]>

	* generic/gdbtk-bp.c (breakpoint_notify): Fix logic error
	when detecting breakpoint types to be handled.

diff --git a/gdb/gdbtk/generic/gdbtk-bp.c b/gdb/gdbtk/generic/gdbtk-bp.c
index 8e752f1..c6e2df9 100644
--- a/gdb/gdbtk/generic/gdbtk-bp.c
+++ b/gdb/gdbtk/generic/gdbtk-bp.c
@@ -605,9 +605,9 @@ breakpoint_notify (int num, const char *action)

    if (b->number < 0
        /* FIXME: should not be so restrictive... */
-      && b->type != bp_breakpoint
-      && b->type != bp_tracepoint
-      && b->type != bp_fast_tracepoint)
+      || (b->type != bp_breakpoint
+         && b->type != bp_tracepoint
+         && b->type != bp_fast_tracepoint))
      return;

    /* We ensure that ACTION contains no special Tcl characters, so we