Re: Master and -Wformat-overflow warning
Tom Hughes <[email protected]>
| Newsgroups | gmane.comp.debugging.valgrind |
|---|---|
| Message-ID | <[email protected]> |
On 02/05/2019 17:02, Mark Wielaard wrote: > Hi Jeffrey, > > On Tue, 2019-04-30 at 20:43 -0400, Jeffrey Walton wrote: >> It looks like GCC has one squawk: >> >> vgdb.c: In function ‘standalone_send_commands’: >> vgdb.c:1008:21: warning: ‘%02x’ directive writing between 2 and 8 >> bytes into a r >> egion of size 3 [-Wformat-overflow=] >> sprintf(hex, "%02x", cksum); >> ^~~~ >> vgdb.c:1008:20: note: directive argument in the range [0, 2147483647] >> sprintf(hex, "%02x", cksum); >> ^~~~~~ > > But cksum is an unsigned char, so value is be between [0, 255]. Which > is max 2 hex chars. It is, but it is technically promoted to int by being passed to a varargs function I think... Tom -- Tom Hughes ([email protected]) http://compton.nu/ _______________________________________________ Valgrind-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/valgrind-users