Re: Valgrind-3.23.0.RC2 is available for testing

I've compiled and tried to run the RC2 on some environments, using

mkdir build
cd build
../configure --enable-lto
make -j8
make -j8 check
make regtest
make perf

and think I've found some things related to the build system (and/or 
documentation).


1. Find just a minor patch for configure.ac to improve help output and 
keep the style of the file (two missing spaces visible in "configure 
--help"; tabs/line breaks).


2. One thing that _may_ be an old issue: all the make targets check, 
regtest and perf fail because of missing g++ on building "bug464969", 
while configure and make pass.


The configure script notes a bunch of "not working" parts related to CXX 
as it tests for the appropriate g++ but even if it doesn't find any 
still do all CXX tests:

configure:5587: checking for g++
configure:5622: result: no
configure:5587: checking for c++
configure:5622: result: no
configure:5587: checking for gpp
configure:5622: result: no
--
configure:5587: checking for clang++
configure:5622: result: no
configure:5646: checking for C++ compiler version
configure:5655: g++ --version >&5
../configure: eval: line 5657: g++: Permission denied
configure:5666: $? = 127
configure:5655: g++ -v >&5
../configure: eval: line 5657: g++: Permission denied
configure:5666: $? = 127
configure:5655: g++ -V >&5
../configure: eval: line 5657: g++: Permission denied
configure:5666: $? = 127
configure:5655: g++ -qversion >&5
../configure: eval: line 5657: g++: Permission denied
configure:5666: $? = 127
configure:5670: checking whether the compiler supports GNU C++
configure:5690: g++ -c   conftest.cpp >&5
../configure: eval: line 2083: g++: Permission denied
configure:5690: $? = 127
configure:5711: checking whether g++ accepts -g
configure:5732: g++ -c -g  conftest.cpp >&5
../configure: eval: line 2083: g++: Permission denied
configure:5748: g++ -c   conftest.cpp >&5
../configure: eval: line 2083: g++: Permission denied
configure:5748: $? = 127
configure:5796: checking for g++ option to enable C++11 features
configure:5811: g++  -c   conftest.cpp >&5
../configure: eval: line 2083: g++: Permission denied
[more to come]
configure:19286: checking if g++ supports __sync_add_and_fetch
configure:19313: g++ -o conftest -m64   conftest.cpp  >&5
../configure: eval: line 2424: g++: Permission denied


As "make" did not fail I deduce that CXX is only optional, in this case 
it would be useful to:

* skip all CXX related tests in configure if it isn't found as an
   executable
* skip all g++ related tests in "make check", "make regtest", "make perf".


3. "make regtest" fails in my out-of-tree build (where "make check" 
executed without errors)

../gdbserver_tests/make_local_links /usr/bin/gdb
if /usr/bin/perl tests/vg_regtest gdbserver_tests memcheck cachegrind 
callgrind helgrind drd massif dhat lackey none exp-bbv ; then \
    tests/post_regtest_checks /home/build/valgrind-3.23.0.RC2/build/.. 
gdbserver_tests memcheck cachegrind callgrind helgrind drd massif dhat 
lackey none exp-bbv; \
else \
    tests/post_regtest_checks /home/build/valgrind-3.23.0.RC2/build/.. 
gdbserver_tests memcheck cachegrind callgrind helgrind drd massif dhat 
lackey none exp-bbv; \
    false; \
fi
sh: 0: cannot open 
/home/build/valgrind-3.23.0.RC2/build/tests/platform_test: No such file
sh: 0: cannot open 
/home/build/valgrind-3.23.0.RC2/build/tests/platform_test: No such file
sh: 0: cannot open 
/home/build/valgrind-3.23.0.RC2/build/tests/platform_test: No such file
sh: 0: cannot open 
/home/build/valgrind-3.23.0.RC2/build/tests/platform_test: No such file
-- Running  tests in memcheck/tests/linux ------------------------------
vg_regtest: `./filter_stderr' not found or not a file (.)
/bin/bash: line 4: tests/post_regtest_checks: No such file or directory
make: *** [Makefile:1442: regtest] Error 1


4. "make perf" outputs
== 0 programs, 0 timings =================


Kind regards and thank you for improving valgrind!
Simon


Am 25.04.2024 um 01:33 schrieb Mark Wielaard:
> An RC2 tarball for 3.23.0 is now available at
> https://sourceware.org/pub/valgrind/valgrind-3.23.0.RC2.tar.bz2
> (md5sum = c1540fb2d48648666f1479d3e44154be)
> (sha1sum = 85438bfae1e03a42cacda0a7a4071c49eaa97f96)
> https://sourceware.org/pub/valgrind/valgrind-3.23.0.RC2.tar.bz2.asc
> 
> Changes since RC1
> 
> Andreas Arnez (1):
>    s390x: Improve operand names in trackers for PRNO
> 
> Mark Wielaard (11):
>    32 bit new_delete_mismatch_size and sized_aligned_new_delete_misaligned .exp
>    Add new .exp-32 files to memcheck/tests/Makefile.am EXTRA_DIST
>    filter out in /absolute/path in drd/tests stderr filter
>    Filter away "main" differences in filter_fdleak
>    VG_(show_open_fds) Only emit empty line when not creating xml output
>    Add dl_new_hash suppression to drd/tests/std_thread2.supp
>    Add another drd/tests/bar_bad exp variant.
>    Add new bar_bad exp files to drd/tests/Makefile.am (EXTRA_DIST).
>    Add prereqs for tests using python 3.9+
>    glibc-2.X-helgrind.supp.in: Also recognize variants on gethostbyname2_r
>    Set version to 3.23.0-RC2
> 
> Paul Floyd (6):
>    FreeBSD suppression: add a suppression for __swbuf seen on arm64
>    FreeBSD suppression: reachable for setlocale
>    FreeBSD suppressions: yet more reachables
>    FreeBSD suppression: puts reachable
>    FreeBSD syswrap: wrong length for __sysctlbyname(name)
>    FreeBSD syscall: add wrapper for kcmp
> 
> Please give it a try in configurations that are important for you and
> report any problems you have, either on this mailing list, or
> (preferably) via our bug tracker at
> https://bugs.kde.org/enter_bug.cgi?product=valgrind
> 
> If nothing critical emerges, a final release will happen on
> Friday 26 April.
> 
> 
> _______________________________________________
> Valgrind-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/valgrind-users
>

_______________________________________________
Valgrind-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/valgrind-users

 AC_CACHE_CHECK([for using the link time optimisation], vg_cv_lto,
    [AC_ARG_ENABLE(lto,
-      [  --enable-lto          enables building with link time optimisation],
+      [  --enable-lto            enables building with link time optimisation],
       [vg_cv_lto=$enableval],
 
 AC_CACHE_CHECK([for TLS support], vg_cv_tls,
-	       [AC_ARG_ENABLE(tls, [  --enable-tls            platform supports TLS],
-		[vg_cv_tls=$enableval],
+   [AC_ARG_ENABLE(tls,
+      [  --enable-tls            platform supports TLS],