Re: Don't ask option for unmounting

Tony Houghton <[email protected]> Sun, 31 May 2009 17:33:53 +0100
Newsgroups gmane.comp.desktop.rox.devel
Message-ID <[email protected]>
On Sun, 31 May 2009 17:29:51 +0200
Bernard Jungen <[email protected]> wrote:

> On Fri, May 29, 2009 at 07:50:35PM +0100, Tony Houghton wrote:
> > On Fri, 29 May 2009 16:45:21 +0200
> > Bernard Jungen <[email protected]> wrote:
> > > By the way, are we sure GPOINTER_TO_INT(NULL) always yields 0? It's assumed in
> > > filer_get_unmount_action().
> > 
> > I've changed the enum initialiser to use the former, just in case.
> 
> Mmmh, quite an unexpected fix! Alas, it doesn't work in all cases, unless the
> code to parse the value from file is fixed too. :-( See attachment.

Ah, I think ISWYM: if we can't assume NULL casts to 0, we can't assume
single digit values either.

I'll leave it up to Thomas to apply this to the main branch.

-- 
TH * http://www.realh.co.uk

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com