Re: ROX-Filer focus problem still there
Nicola Fontana <[email protected]> Sat, 18 Feb 2012 15:47:57 +0100
| Newsgroups | gmane.comp.desktop.rox.devel |
|---|---|
| Organization | eNTiDi |
| Message-ID | <[email protected]> |
--MP_/P.4E4Htd3ArEAjuFhvHKuLL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Il giorno Sat, 18 Feb 2012 16:23:15 +0800 Barry Kauler <[email protected]> ha scritto: > > I originally reported an icon focus problem, that Thomas fixed, see > > patch from Thomas: > > http://repo.or.cz/w/rox-filer.git/commit/c2232d5075342347a8ff814ced5ce8b9e1cf64b9 I attached a patch that extends the above fix to "Send to...", together with another patch that let me build ROX-Filer on my system. > > ...which did fix the problem, partly. However, even that fix no longer > > works. > > > > It may be because Puppy Linux has progressed to GTK 2.24.8. Back then, > > I think we were using GTK 2.18.x or 2.21.x. > > > > Back then, after applying Thomas's patch, I found that there was still > > a problem, that I reported: > > https://sourceforge.net/tracker/?func=detail&aid=3147977&group_id=7023&atid=107023 This is another issue. For what I can understand from the code, this is expected and only happens with multiple selection. Ciao. -- Nicola --MP_/P.4E4Htd3ArEAjuFhvHKuLL Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Add-explicit-dependency-on-libm-and-libdl.patch >From b7cb91e8800f9c9d9b64cd4477b668b41cbed3fc Mon Sep 17 00:00:00 2001 From: Nicola Fontana <[email protected]> Date: Sat, 18 Feb 2012 15:14:03 +0100 Subject: [PATCH 1/2] Add explicit dependency on libm and libdl Math and dynamic loading functions could be defined in external libraries not directly included by default, so explicit checking is required at configure level. An alternative approach to AC_CHECK_LIB would be AC_SEARCH_LIBS, a not so conventional method with possibly some advantage: http://www.flameeyes.eu/autotools-mythbuster/autoconf/finding.html --- ROX-Filer/src/configure.in | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/ROX-Filer/src/configure.in b/ROX-Filer/src/configure.in index cc5ff87..44759f3 100644 --- a/ROX-Filer/src/configure.in +++ b/ROX-Filer/src/configure.in @@ -173,6 +173,9 @@ AC_TYPE_SIZE_T dnl Checks for library functions. AC_CHECK_FUNCS(gethostname unsetenv mkdir rmdir strdup strtol statvfs statfs mbrtowc) +dnl Math functions and dlsym() could be defined outside the standard C library +AC_CHECK_LIB(m, floor) +AC_CHECK_LIB(dl, dlsym) dnl Since we're using libintl.h, check if libintl needs to be linked in AC_CHECK_LIB(intl, gettext) -- 1.7.9.1 --MP_/P.4E4Htd3ArEAjuFhvHKuLL Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0002-Extend-commit-c2232d50-to-Send-to.patch >From 7b7ad9f3e8dc91d08050c7b24ecae603b64ca52f Mon Sep 17 00:00:00 2001 From: Nicola Fontana <[email protected]> Date: Sat, 18 Feb 2012 15:14:22 +0100 Subject: [PATCH 2/2] Extend commit #c2232d50 to "Send to..." --- ROX-Filer/src/menu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ROX-Filer/src/menu.c b/ROX-Filer/src/menu.c index bf4bae3..a9ec107 100644 --- a/ROX-Filer/src/menu.c +++ b/ROX-Filer/src/menu.c @@ -1674,7 +1674,7 @@ static void show_send_to_menu(GList *paths, GdkEvent *event) send_to_paths = paths; - g_signal_connect(menu, "unmap_event", G_CALLBACK(menu_closed), NULL); + g_signal_connect(menu, "selection-done", G_CALLBACK(menu_closed), NULL); popup_menu = menu; show_popup_menu(menu, event, 0); -- 1.7.9.1 --MP_/P.4E4Htd3ArEAjuFhvHKuLL Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ --MP_/P.4E4Htd3ArEAjuFhvHKuLL Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ rox-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/rox-devel --MP_/P.4E4Htd3ArEAjuFhvHKuLL--