Re: Coherent naming for backdrop styles

Stephen Watson <[email protected]> Sat, 17 Mar 2012 16:10:16 +0000
Newsgroups gmane.comp.desktop.rox.devel
Message-ID <[email protected]>
Greygjhart <[email protected]> wrote:

> Hello there,
> 
> I had a very hard time trying to figure out what I was expected to write
> to get a RPC command to actually set my wallpaper in a given mode. Of
> course my first instinct was to look at the config file to find a hint,
> as I could perfectly set it with rox' utility.
> 
> I was very surprised to find that what was called Centred in one was
> Centre in the other one, and that's the same for others, though there
> doesn't seem to be any generality here. As I still could manage to get
> the 'Fit' mode to work (even after having commited atrocities like
> 'Fitted' or such), I proceeded to read the source code.
> 
> This is when I was flabbergasted to discover that Fit mode wasn't even
> possible to set with a RPC command because its line had obviously been
> forgotten.
> 
> I promised I searched a long time on the forum but I couldn't find any
> topic mentioning that. Plus, it's not really a feature request or a bug
> report, it's just a tiny mistake that takes no time to correct so I
> really think it would've been corrected at once.
> 
> So here is the patch I propose to solve this issue and use the same
> names everywhere (in the config and in the RPC commands).

Changing the names used in the config isn't really viable as it would
invalidate existing configuration files.  The missing Fit in RPC is a
genuine bug, as is the lack of a mention of Stretch in the manual.

-- 
Stephen Watson     http://www.kerofin.demon.co.uk/
If you read this on a mailing list, send any reply back to the list and not
to me.  Not even CC.
"Daleks have no concept of elegance!" "That is obvious."

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure