Launch buttons in the options dialog now look for a locally installed app
"Thomas Leonard" <[email protected]>
| Newsgroups | gmane.comp.desktop.rox.devel |
|---|---|
| Message-ID | <[email protected]> |
Looking at commit 11ce57102f89a7dad707d1a2f050749c4507414f (kerofin):
+/* Search for a application on $APPDIRPATH
+ * (~/Apps:/usr/local/apps:/usr/apps) and return a copy of the path found.
+ * Returns NULL if not found
+ */
+gchar *find_app(const char *appname)
+{
+ const gchar *path=g_getenv(appname);
+ gchar **search;
Why does it call g_getenv on appname?
Also:
+ for(i=0; search[i]; i++)
+ {
+ app=g_strconcat(search[i], "/", appname, NULL);
+ if(access(app, X_OK)==0)
+ goto out;
+ }
Missing a g_free?
--
Dr Thomas Leonard ROX desktop / Zero Install
GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php