Better "select by name" behavior

Dennis Nezic <[email protected]> Thu, 31 Jan 2013 13:31:46 -0500
Newsgroups gmane.comp.desktop.rox.user
Message-ID <[email protected]>
So, currently (rox-2.10), when you MINI_SELECT_BY_NAME (. command), it
defaults to the "*." glob -- i.e. it assumes we want to select by a
certain file extension. I found that I usually wasn't searching by file
extension, but rather by keywords within filenames, and often found
myself having to backspace. So, I think it would be better to not have
that initial default glob.

Also, when matches were found, although they were selected, the window
wouldn't scroll to them (if they weren't visible -- ie. in a folder
with many files.) I think the window should jump to the first match,
much like the current MINI_PATH does. This little patch here does
something like that, although I'm not sure if it's the best way :P --
it will move the window and the non-highlighted-selected entry down one
each time a new glob is matched.

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan

_______________________________________________
rox-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rox-users
better-select-by-name.patch (application/octet-stream, 728 B)
--- rox-filer-2.10/ROX-Filer/src/minibuffer.c	2009-07-18 10:23:18.000000000 -0400
+++ ./minibuffer.c	2013-01-31 10:56:59.000000000 -0500
@@ -153,9 +153,8 @@
 			filer_window->mini_cursor_base = -1;	/* History */
 			break;
 		case MINI_SELECT_BY_NAME:
-			gtk_entry_set_text(mini, "*.");
+			gtk_entry_set_text(mini, "");
 			filer_window->mini_cursor_base = -1;	/* History */
-			view_select_if(filer_window->view, select_if_glob, "*.");
 			break;
 		case MINI_FILTER:
 			if(filer_window->filter!=FILER_SHOW_GLOB ||
@@ -1088,6 +1087,7 @@
 					select_if_glob,
 					(gpointer) gtk_entry_get_text(
 					      GTK_ENTRY(filer_window->minibuffer)));
+			filer_next_selected(filer_window, 1);
 			return;
 		default:
 			break;