[PATCH 4/4] clock: binary: remove redundant code
Felipe Contreras <[email protected]> Wed, 3 Aug 2022 17:30:35 -0500
| Newsgroups | gmane.comp.desktop.xfce.devel.version4 |
|---|---|
| Message-ID | <[email protected]> |
The code does exactly the same whether or not the insensitive flag is set, so there's no point in checking it. Signed-off-by: Felipe Contreras <[email protected]> --- plugins/clock/clock-binary.c | 48 +++++++++--------------------------- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/plugins/clock/clock-binary.c b/plugins/clock/clock-binary.c index 10d69d03..7a9ce6a1 100644 --- a/plugins/clock/clock-binary.c +++ b/plugins/clock/clock-binary.c @@ -274,24 +274,12 @@ xfce_clock_binary_draw_true_binary (XfceClockBinary *binary, ctx = gtk_widget_get_style_context (GTK_WIDGET (binary)); - if (G_UNLIKELY (gtk_widget_get_state_flags (GTK_WIDGET (binary)) & GTK_STATE_FLAG_INSENSITIVE)) - { - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &inactive_rgba); - inactive_rgba.alpha = 0.2; - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &active_rgba); - active_rgba.alpha = 1.0; - } - else - { - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &inactive_rgba); - inactive_rgba.alpha = 0.2; - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &active_rgba); - active_rgba.alpha = 1.0; - } + gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), + &inactive_rgba); + inactive_rgba.alpha = 0.2; + gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), + &active_rgba); + active_rgba.alpha = 1.0; time = clock_time_get_time (binary->time); @@ -371,24 +359,12 @@ xfce_clock_binary_draw_binary (XfceClockBinary *binary, ctx = gtk_widget_get_style_context (GTK_WIDGET (binary)); - if (G_UNLIKELY (gtk_widget_get_state_flags (GTK_WIDGET (binary)) & GTK_STATE_FLAG_INSENSITIVE)) - { - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &inactive_rgba); - inactive_rgba.alpha = 0.2; - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &active_rgba); - active_rgba.alpha = 1.0; - } - else - { - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &inactive_rgba); - inactive_rgba.alpha = 0.2; - gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), - &active_rgba); - active_rgba.alpha = 1.0; - } + gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), + &inactive_rgba); + inactive_rgba.alpha = 0.2; + gtk_style_context_get_color (ctx, gtk_widget_get_state_flags (GTK_WIDGET (binary)), + &active_rgba); + active_rgba.alpha = 1.0; time = clock_time_get_time (binary->time); -- 2.37.1.313.g01a229ef5e _______________________________________________ Xfce4-dev mailing list [email protected] https://mail.xfce.org/mailman/listinfo/xfce4-dev