Re: xfdesktop: globals or not ?

On 01.11.22 03:23, Brian Tarricone wrote:

Hi,

> I generally dislike globals (though admittedly I'm probably responsible
> for most of the globals in xfdesktop, when I was younger and more foolish).

okay, then we should move them into objects ?

> A warning, first, though: I intend to merge my Wayland branch shortly after 
> branching for 4.18, so you may want to hold off on changes that touch a bunch
> of files and code, as you'll likely have some merge conflicts to deal with.

I'm not scared of rebasing ;-)

> Right now I am holding off on merging or engaging in any elective refactoring; 
> since xfdesktop doesn't have a test suite, I'd rather not make a bunch of 
> unnecessary changes before the 4.18 release.

Thats okay, I can hold my stuff in a separate branch and rebase later,
even if it needs heavy rewrites. I'm used to such workflows.

> Also I'm planning a bunch of refactoring myself, though likely mostly around the icon view code.
>  So let's do our best not to have MRs that try to fight each other :)

Wouldn't call competing or conflicting MRs as fight - let the best
ones win :)


--mtx

> 
>       -brian
> _______________________________________________
> Xfce4-dev mailing list
> [email protected]
> https://mail.xfce.org/mailman/listinfo/xfce4-dev

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287
_______________________________________________
Xfce4-dev mailing list
[email protected]
https://mail.xfce.org/mailman/listinfo/xfce4-dev