Re: ANNOUNCE: thunar 4.21.3 released

Manfred Hollstein <[email protected]> Fri, 17 Oct 2025 13:45:14 +0200
Newsgroups gmane.comp.desktop.xfce.devel.version4
Message-ID <[email protected]>
--===============1821850509815080499==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="pcH0sV/9Z14RCpY/"
Content-Disposition: inline


--pcH0sV/9Z14RCpY/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi there,

On Thu, 16 Oct 2025, 08:36:07 +0200, Alexander Schwinn wrote:
> thunar 4.21.3 is now available for download from
>  =20
>   https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz
>   https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz?sha1
>   https://archive.xfce.org/src/xfce/thunar/4.21/thunar-4.21.3.tar.xz?sha2=
56

while "terminal" is an optional feature, thunar/thunar-preferences.c
uses some of the optional constants unconditionally. If vte-devel is not
installed in the build environment, building the new version fails. The
patch below fixes this.

HTH, cheers.

l8er
manfred


- Properly wrap all occurrences of PROP_TERMINAL_* in thunar/thunar-prefere=
nces.c


diff -rup a/thunar/thunar-preferences.c b/thunar/thunar-preferences.c
--- a/thunar/thunar-preferences.c	2025-10-16 08:22:21.000000000 +0200
+++ b/thunar/thunar-preferences.c	2025-10-17 13:37:12.009861792 +0200
@@ -1498,6 +1498,7 @@ thunar_preferences_class_init (ThunarPre
                      THUNAR_FILE_DRAG_MODE_MENU_ALWAYS,
                      G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
=20
+#ifdef HAVE_VTE
   /**             =20
    * ThunarPreferences:terminal-height:
    *
@@ -1511,7 +1512,9 @@ thunar_preferences_class_init (ThunarPre
                     G_MAXINT,                            /* max height */
                     200,                                 /* default height=
 */
                     G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
+#endif
=20
+#ifdef HAVE_VTE
   /**
    * ThunarPreferences:terminal-visible:
    *
@@ -1523,7 +1526,9 @@ thunar_preferences_class_init (ThunarPre
                         NULL,
                         FALSE,
                         G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
+#endif
=20
+#ifdef HAVE_VTE
   /**
    * ThunarPreferences:terminal-color-scheme:
    *
@@ -1535,7 +1540,9 @@ thunar_preferences_class_init (ThunarPre
                        NULL,
                        "system",
                        G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
+#endif
=20
+#ifdef HAVE_VTE
   /**
    * ThunarPreferences:terminal-sync-mode:
    *
@@ -1548,7 +1555,9 @@ thunar_preferences_class_init (ThunarPre
                      THUNAR_TYPE_TERMINAL_SYNC_MODE,
                      THUNAR_TERMINAL_SYNC_BOTH,
                      G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
+#endif
=20
+#ifdef HAVE_VTE
   /**
    * ThunarPreferences:terminal-ssh-auto-connect:
    *
@@ -1560,7 +1569,9 @@ thunar_preferences_class_init (ThunarPre
                         NULL,
                         FALSE,
                         G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
+#endif
=20
+#ifdef HAVE_VTE
   /**
    * ThunarPreferences:terminal-ssh-auto-disconnect:
    *
@@ -1572,6 +1583,7 @@ thunar_preferences_class_init (ThunarPre
                         NULL,
                         FALSE,
                         G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
+#endif
=20
 #ifdef HAVE_VTE
   /**

--pcH0sV/9Z14RCpY/
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJPBAABCAA5FiEEYi2tNR04t+DbYB/qr3aTLzTrAekFAmjyLEobFIAAAAAABAAO
bWFudTIsMi41KzEuMTEsMiwyAAoJEK92ky806wHpeYsP/3Uo9MHPSYDk3AqH2W2I
e1kLlBva102nnGvkDv5C/CI8i3UVn8wur3dbCfsMDXVSgt+2uZMJZ2AcX0smjrwA
nM+SHavl6HWoTkqtRtHOroseZ/BWBXXa99KLciPiFzo7/QkfVP2F1rHJx3NAJIGf
R7LCSTXuBYIhAMDKAUAbgAytz75dCmf19VsvVrdTtLi6JUta49t6oP8D3HuZl4r0
agS9IIxW8GSigE8JYOqJtxTKNDW+KlkWOjemA2CiH3A0ZaIutgnGC0N2qCqOj3p/
DDAakwMFOnuh1q2x1aUbAMVnoxBIWTLkPvtT+30vkRTXmvovEpg1c8+SUNwb3TlI
wu9Pm6b2FB+mKolQdOG08l47WWEVU4pAgObH9uLplu7PtPahkTi5ZOm8iZz/8FE5
hYT+q3rRudtF1X7C0R2xMc9LcRJNkPSkW6q3sBvhmayYNZEc5JMw/Lx/IqeUXXz3
id4QtXZ3sr7/1Yl5AEtJsp+qrygh3ACwcPcpBqw/FDCtk9AlnYmy+MYV5Hwe2jBD
0l8RsJUtKx57wdKg/3jDRCe7bx3L2Fy2e5wJzQABmLqnJPAX/GkPwqeSThl3R8qf
hrxTinpkTbfApDEzc9LLfYHm33tK2ejsTbDTuivBB/4VFEbaJ6v3ofCf4xHwIAwT
OPk3v3Hjy21zMUZVwbCdKEzA
=XFpX
-----END PGP SIGNATURE-----

--pcH0sV/9Z14RCpY/--

--===============1821850509815080499==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xfce4-dev mailing list
[email protected]
https://mail.xfce.org/mailman/listinfo/xfce4-dev

--===============1821850509815080499==--