[Bug 1337] port to 4.3

Do NOT reply to this email.  To make further comments on this bug, use
the URL below:
http://bugzilla.xfce.org/show_bug.cgi?id=1337


[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[email protected] |[email protected]




------- Additional Comments From [email protected]  2006-01-22 09:21 UTC -------
Great, thanks, I have a couple of comments:

- gdk_pixbuf_scale_simple returns a newly created pixbuf, so this leaks memory:

static void
showdesktop_update_icon (ShowDesktopData * sdd, int size)
{
    GdkPixbuf *pb = gdk_pixbuf_copy (sdd->icon);

    gdk_pixbuf_scale_simple (pb, size, size, GDK_INTERP_BILINEAR);
    xfce_scaled_image_set_from_pixbuf (XFCE_SCALED_IMAGE (sdd->image), pb);
    g_object_unref (G_OBJECT (pb));
}

- also, the purpose of the scaled image is to scale automatically, so this is
not needed at all. You can simple create the image once and set the size of the
button.

- If all you want to do in the set_size callback is change the button size, you
don't need to do anything, since this is the default behavior if there is no
callback.

- A question: what happens when a user manually de-iconifies a window? Does the
window manager reset the 'show desktop' state? In that case we need to reset the
button as well, I guess.



-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.