Re: ANNOUNCE: Verve 0.1.0 - A panel command line plugin

On Sun, 12 Feb 2006 10:55:41 +0100
Jasper Huijsmans <[email protected]> wrote:

> Daichi Kawahata schreef:
> > Hi Jannis, Jasper,
> > 
> > On Sat, 11 Feb 2006 22:24:47 +0100
> > Jasper Huijsmans wrote:
> > 
> >>> ** (xfce4-panel:4182): CRITICAL **: Ein Item wurde unerwartet
> >>> entfernt: "Verve-Kommandozeile".
> > 
> > I got the same,
> > 
> > (xfce4-panel:653568): Gdk-WARNING **: gdkdrawable-x11.c:904 \
> >   drawable is not a pixmap or window
> > 
> > ** (xfce4-panel:653568): CRITICAL **: An item was unexpectedly
> > removed: \ "Verve Command Line".
> > 
> >> Well, it basically means your plugin crashes. Maybe I have
> >> different libraries/dependencies installed, so my plugin may
> >> not trigger the crash.
> >>
> >> I have to think about how to debug an external plugin properly.
> >> Hmm, it would be kinda cool to have 'xfce4-<name>-plugin --debug'
> >> which would run the plugin in a separate window...
> > 
> > From the crash above, I got a core dumped by xfce4-verve-plugin,
> > attached stack trace shows a similar path to the crash though.
> > 
> > FYI Jannis, the installations in my machine are different from
> > Linux's, i.e. my working SHELL is /usr/freeware/bin/bash,
> > haven't PHP installed etc. which may cause a problem at frame
> > 2 (while compile flag has `-g', it says `No locals.' in the
> > full trace).
> > 
> > Regards,
> 
> Daichi, Jannis, please try the attached patch. I replaced 
> g_strv_length() with G_N_ELEMENTS(). The first is only valid for NULL 
> terminated arrays.

Ah, that makes sense. Didn't know about that, because I'm new to GTK+.
I applied the patch and it seems to work. I'm going to commit it in a
second.

Thanks,
Jannis

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFD7xOJwkthCKq3fe0RAjceAKCHXusr3/5FBMzVuv67STipksd/GgCeMIHc
EBfk0+i3wskBioidMJo9qP0=
=jXrS
-----END PGP SIGNATURE-----