Re: [Synopsis-changes] r1851 - in branches/Synopsis_0_8/Synopsis: Formatters dist/command

On Fri, Jan 18, 2008 at 12:27:39PM +0000, [email protected] wrote:
>Author: stefan
>Date: 2008-01-18 12:27:38 +0000 (Fri, 18 Jan 2008)
>New Revision: 1851
>
>Modified:
>   branches/Synopsis_0_8/Synopsis/Formatters/TOC.py
>   branches/Synopsis_0_8/Synopsis/dist/command/build_doc.py
>Log:
>Fix build_doc command.
>
>Modified: branches/Synopsis_0_8/Synopsis/Formatters/TOC.py
>===================================================================
>--- branches/Synopsis_0_8/Synopsis/Formatters/TOC.py	2008-01-18 04:43:04 UTC (rev 1850)
>+++ branches/Synopsis_0_8/Synopsis/Formatters/TOC.py	2008-01-18 12:27:38 UTC (rev 1851)
>@@ -96,7 +96,7 @@
>             name = name[:-1] + [name[-1]+scopedname[param_index:]]
>          else:
>             name = scopedname.split('::')
>-         if len(url): link = [url, link].join('/')
>+         if len(url): link = '/'.join([url, link])

shouldn't this be os.path.join(url,link) or the like to be gentle to Windows?
>          entry = TOC.Entry(name, link, lang, "decl")
>          self.insert(entry)
>          line = fin.readline()
>
>Modified: branches/Synopsis_0_8/Synopsis/dist/command/build_doc.py
>===================================================================
>--- branches/Synopsis_0_8/Synopsis/dist/command/build_doc.py	2008-01-18 04:43:04 UTC (rev 1850)
>+++ branches/Synopsis_0_8/Synopsis/dist/command/build_doc.py	2008-01-18 12:27:38 UTC (rev 1851)
>@@ -237,10 +237,11 @@
>       builddir = os.path.abspath(os.path.join(self.build_lib,
>                                               'share/doc/synopsis'))
> 
>+      # Copy examples output into installation directory
>       if os.path.isdir(os.path.join(builddir, 'html/examples')):
>-               rmtree(os.path.join(builddir, 'html/examples'), 1)
>-               copy_tree(os.path.join(tempdir, 'html/examples'),
>-                         os.path.join(builddir, 'html/examples'))
>+         rmtree(os.path.join(builddir, 'html/examples'), 1)
>+      copy_tree(os.path.join(tempdir, 'html/examples'),
>+                os.path.join(builddir, 'html/examples'))

os.path.join(builddir, 'html', 'examples') which would use the proper
os.sep ?

Just curious..
cheers,