Re: PNG support

On Tue, 2003-07-22 at 09:09, Marc Strämke wrote:
> Hi ppl :)
> The image class now uses offscreen surfaces and libpng for loading, test 
>   it and break it please :) (supports rgb and rgba PNGs)
> 

image class code review follows...

- nice impl Marc.  thanks for adding libpng.

- /me notes carter's aversion to whitespace (a=b instead of a = b, a,b,c
instead of a, b, c - coding_style standards).  Perhaps we should relax
them or modify them, but I think we would like the library code to be
uniform.  Does anyone else care, or am I just being anal?

- lets find a way to let CVS update the LAST UPDATE field, it's too easy
to forget to do.

- A question on style: do we want to use the stk:: prefix in the
headers? I vote "nay" since we are already inside the namepsace stk { 
... } block.

- since application is a singleton, you can avoid passing the
onscreen_surface by referencing application::get()->surface() when it's
needed.  But that would limit us to drawing to the main surface... which
might not be what we want (but atm is the only option).

- the change severly broke the build.  surface_fbdev, and several
test_apps don't build, and test_app segfaults.  we should be careful to
update ALL the tests and to implement at least error logging
implementations of new purely virtual methods added to the abstract base
classes before we commit changes.


Darren

> 
> 
> _______________________________________________
> Libstk mailing list
> [email protected]
> http://www.dvhart.com/cgi-bin/mailman/listinfo/libstk