Re: [PATCH v2 50/53] qdev: simplify DEFINE_PROP_ARRAY and remove generic array PropertyInfo

Markus Armbruster <[email protected]> writes:

> Marc-André Lureau <[email protected]> writes:
>
>> Change DEFINE_PROP_ARRAY, the macro now uses _arrayprop##_list to
>> resolve the typed list PropertyInfo (introduced in the previous patch)
>> instead of the generic qdev_prop_array.
>>
>> This means the element type and size information is carried by the
>> PropertyInfo itself rather than duplicated at each callsite. Since
>> the typed list PropertyInfos encode element_info and element_size,
>> the .arrayinfo and .arrayfieldsize fields are no longer set by the
>> macro (they will be removed from the Property struct in the next patch).
>>
>> Remove qdev_prop_array, which is now unused.
>>
>> Signed-off-by: Marc-André Lureau <[email protected]>
>
> [...]
>
>> diff --git a/hw/intc/arm_gicv5_common.c b/hw/intc/arm_gicv5_common.c
>> index b155486af65..61c8ae49302 100644
>> --- a/hw/intc/arm_gicv5_common.c
>> +++ b/hw/intc/arm_gicv5_common.c
>> @@ -191,9 +191,9 @@ static void gicv5_common_realize(DeviceState *dev, Error **errp)
>>  
>>  static const Property arm_gicv5_common_properties[] = {
>>      DEFINE_PROP_LINK_ARRAY("cpus", GICv5Common, num_cpus,
>> -                           cpus, TYPE_ARM_CPU, ARMCPU *),
>> +                           cpus, TYPE_ARM_CPU),
>>      DEFINE_PROP_ARRAY("cpu-iaffids", GICv5Common, num_cpu_iaffids,
>> -                      cpu_iaffids, qdev_prop_uint32, uint32_t),
>> +                      cpu_iaffids, qdev_prop_uint32),
>>      DEFINE_PROP_UINT32("irsid", GICv5Common, irsid, 0),
>>      DEFINE_PROP_UINT32("spi-range", GICv5Common, spi_range, 0),
>>      DEFINE_PROP_UINT32("spi-base", GICv5Common, spi_base, 0),
>
> Doesn't compile for me.  I applied the series at merge commit
> 8333dba732.  If it compiles for you, could you push it to where I can
> pull?

I just found base-commit: 2f28d34ea0aead9830478cd1d3d0dd9d9191d82e in
your cover letter, and I'm going to try it.

[...]