Re: [PATCH] vhost: do not crash on ring map failure
Stefano Garzarella <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu |
|---|---|
| Message-ID | <amhn4yvmMmAFZOy3@sgarzare-redhat> |
On Fri, Jul 24, 2026 at 09:07:47AM -0400, Michael S. Tsirkin wrote:
>When vhost_commit() rebuilds the memory region table after a flatview
>change, it revalidates cached host virtual addresses for active vring
>parts. If a mapping is stale, QEMU abort().
>
>This is not a security problem - only the priviledged guest
>can control make it invalid - but not nice e.g. for driver debugging.
>
>Let's call virtio_error() instead, marking the device as broken.
>
>Fixes: 0ca1fd2d68 ("vhost: Simplify ring verification checks")
>Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3783
>Cc: Stefano Garzarella <[email protected]>
>Cc: Dr. David Alan Gilbert <[email protected]>
>Signed-off-by: Michael S. Tsirkin <[email protected]>
>---
> hw/virtio/vhost.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella <[email protected]>